Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust skeleton covers to full height #596

Conversation

kasperbirch1
Copy link
Contributor

Link to issue

https://reload.atlassian.net/browse/DDFFORM-490

Description

This pull request ensures the correct sizes for skeletons and prevents content jumping during loading.

@LasseStaus LasseStaus force-pushed the DDFFORM-490-paragraph-material-grid-mobil-i-os-felter-forskellig-storrelse branch from e19f149 to 0512e21 Compare April 18, 2024 10:41
These changes aim to:
- Ensure that the individual recommended-materials in the grid, will "fill out" their respective part of the grid.

- Skeletons / non-skeletons should be equally large.

- That the content will not jump depending on the cover image frame.

DDFFORM-490
@LasseStaus LasseStaus force-pushed the DDFFORM-490-paragraph-material-grid-mobil-i-os-felter-forskellig-storrelse branch from c8dfa2e to 413ca14 Compare April 18, 2024 16:23
@LasseStaus
Copy link
Contributor

superseded by #600

@LasseStaus LasseStaus closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants